Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent useOnChainId unnecessary refreshes #1142

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: prevent useOnChainId unnecessary refreshes #1142

merged 1 commit into from
Nov 8, 2023

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Nov 7, 2023

Prevents useOnChainId(address) from refetching data each time it's called

test case : navigate back & forth between popup home page and one account's page

chidg
chidg approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKheops 0xKheops merged commit 228731b into dev Nov 8, 2023
4 checks passed
@0xKheops 0xKheops deleted the fix/onchain-id-prevent-refresh branch November 8, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg chidg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xKheops @chidg